-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new dynamic folder mode parameter on Cloudinary #110
Open
RandyCupic
wants to merge
12
commits into
upgrade-cloudinary-php-api
Choose a base branch
from
feature/folder-mode
base: upgrade-cloudinary-php-api
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandyCupic
force-pushed
the
upgrade-cloudinary-php-api
branch
from
September 11, 2024 18:40
5744520
to
66e4b7c
Compare
RandyCupic
force-pushed
the
feature/folder-mode
branch
from
September 17, 2024 18:57
a9f4d21
to
ef66ac3
Compare
RandyCupic
force-pushed
the
upgrade-cloudinary-php-api
branch
from
September 19, 2024 16:13
5da99ef
to
534a2f0
Compare
RandyCupic
force-pushed
the
feature/folder-mode
branch
from
September 19, 2024 16:19
d5be939
to
b55a167
Compare
RandyCupic
changed the title
[WIP] Add support for new dynamic folder mode parameter on Cloudinary
Add support for new dynamic folder mode parameter on Cloudinary
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for new
dynamic
folder_mode
configuration that Cloudinary introduced (and is forcing on all new accounts), while still keeping support for the oldfixed
mode for projects that are currently using it. This can be configured:Also this PR depends on it's parent PR (upgrading Cloudinary PHP API library form v1 to v2) because folder mode is not supported in v1.
TODO: